chore: add e2e smoke test #507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-507.line-listing.netlify.dhis2.org |
martinkrulltott
approved these changes
May 2, 2024
jenniferarnesen
added
the
e2e record
…g-app into chore/e2e-optimization
jenniferarnesen
removed
the
e2e record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the smoke test before running the entire suite to reduce failing runs due to login or settings problems. The actual changes are here (rest of e2e-prod is exact copy from the shared workflow):
https://github.com/dhis2/line-listing-app/pull/507/files#diff-3de8e35d5b45d4311c2d0938f1dc140bfc8f5162e23f4fc4ef3262de605f5408R98-R116
Note that the smoke test runs both in the e2e smoke step and the e2e step. This could be prvented by using subfolders under the /integration folder, and setting the
specproperty for bothRun e2e smokestep andRun e2e teststep. I didn't do this because the smoke suite is so small and doesn't add much to the total running time.Here you can see that the full suite of tests doesn't run when the smoke tests fail:
For now I've copied the shared workflow to LL to try out the new smoke step. If it seems useful then we can update the shared workflow.